Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added current model indicator with an * when --listmodels is called #687

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mchoccie
Copy link

@mchoccie mchoccie commented Jul 3, 2024

What this Pull Request (PR) does

Trying to add a small and simple feature for my first contribution. Whenever 'fabric --listmodels' is called, the output will denote the currently used model with an asterisk after it. Hopefully this will give users a better idea of the current model they've set Fabric to utilize.

Related issues

closes #446

Screenshots

image

@auryn31
Copy link

auryn31 commented Jul 3, 2024

Just encountered the same thing and would love having it in. Would maybe write a model print helper function, to not have so many if repetitions and only one place to change the pattern of what is the current model and what not
maybe would also have instead of a * something like (current)

@mchoccie
Copy link
Author

mchoccie commented Jul 4, 2024

Hey @auryn31 , I implemented the changes you mentioned. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants