Add a cloud storage for delta sharing #178
Open
+69
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangp-nhlab Thanks for the contribution. Is it possible for us to test this? |
zsxwing
reviewed
Aug 15, 2022
Comment on lines
221
to
223
| name: URI, | ||
| conf: Configuration, | ||
| preSignedUrlTimeoutSeconds: Long) extends CloudFileSigner { |
Reposting this question in case you miss it. |
Okay, sure |
|
@wangp-nhlab do you have an email address? We can sync offline for this. |
Email address: pengw9820@gmail.com |
|
Hi @wangp-nhlab @zsxwing, this patch is very useful to users who use Aliyun OSS, can we push this patch to code repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I used delta sharing in my work and support Aliyun OSS, a Chinese cloud service provider, similar to the AWS S3. We hope to contribute this part of code after completion, and we don't change the code and structure for other functions.