-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorthand for IS_BUILD_MODE #2268
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My standard comment: tests?
Although you could probably get away in this case without writing anything new if you just refactor the one place in the codebase that uses this line to use your new const
:
Line 41 in 34c875c
if (Deno.args.includes("build")) { |
This is executed in the tests, so if it works here, I'd say it's covered.
This change has been put in place. Thanks for the thoughts. |
Just updated the branch |
This is a quick shorthand for IS_BUILD_MODE (Deno.args.includes("build")), should help simplify code that needs to not run during ahead of time builds. Will address #2240 .