Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support numeric keys when rendering #2584

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

deer
Copy link
Contributor

@deer deer commented Jul 7, 2024

I'm trying to migrate one of my projects which publishes a plugin, and this was blocking me.

Looks like key is typed as export type Key = string | number | any;, so we might need to make more changes here in the future.

Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@marvinhagemeister marvinhagemeister merged commit 8413666 into denoland:main Jul 7, 2024
4 of 7 checks passed
@deer deer deleted the support_numeric_keys branch July 7, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants