Support react 17 as peerDependency #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2022 09:46
so this can work in modern applications without fiddling with deps
rebuilt with new dependencies
|
I don't think this is really a fix, you're just removing the dependency check instead of actually refactoring whatever code that relies on React 16. I'm having issues with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #34 peerDependency errors are emitted when using this module with react 17. This change should suppress these errors, we have tested it using a sample video.
Users are welcome to use a deployed artifact of @panelist/react-hls-player until this is merged / #34 is resolved.