Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: Nest dev-config settings under 'dev' #1286

Merged
merged 3 commits into from
Oct 18, 2022
Merged

apps: Nest dev-config settings under 'dev' #1286

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b8c170
auth: Add test for default config file location setting.
andrewsomething Oct 17, 2022
e0369a3
apps: Nest dev-config settings under 'dev'
andrewsomething Oct 18, 2022
dbfb6ec
Don't nest deeper if it is already under 'dev.'
andrewsomething Oct 18, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't nest deeper if it is already under 'dev.'
  • Loading branch information
@andrewsomething
andrewsomething committed Oct 18, 2022
commit dbfb6ec079eeb01c20bf27af211f5f0a112ccef0
2 changes: 1 addition & 1 deletion commands/doit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func AddStringFlag(cmd *Command, name, shorthand, dflt, desc string, opts ...fla
// app dev config set/unset --dev-config flag to be nested deeper.
// i.e dev.config.set.dev-config over config.set.dev-config
// This prevents a conflict with the base config setting.
if name == doctl.ArgAppDevConfig {
if name == doctl.ArgAppDevConfig && !strings.HasPrefix(fn, appDevConfigFileNamespace+".") {
fn = fmt.Sprintf("%s.%s", appDevConfigFileNamespace, fn)
}

Expand Down