Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed domain resources aren't getting cleaned up after acceptance tests but it's difficult to identify which tests aren't properly cleaning up after themselves.
This change includes a few things to help diagnose as well clean up:
testNamePrefix
(a const value set in the digitalocean/provider_test.go#L17)randomTestName()
(which uses the above common prefix)randomTestName()
to allow a list of strings that will get concatenated with-
(and will replace spaces with_
).make sweep
. This will allow the resources to be cleaned up after every acceptance test run regardless of the tests handling clean up properly, and help reduce future errors due to resource limits being reached.