Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Orleans Streaming #8908

Closed
wants to merge 1 commit into from
Closed

fix:Orleans Streaming #8908

wants to merge 1 commit into from

Conversation

gusuchengnan
Copy link

@gusuchengnan gusuchengnan commented Mar 13, 2024 •
edited by dotnet-policy-service bot
Loading

in [SetCursor] method, If last purged token does not exists, do not throw an exception, just start from the oldest message in cache #8863

Microsoft Reviewers: Open in CodeFlow
@gusuchengnan
fix:Orleans Streaming: in [SetCursor] method, If last purged token do…
6d8a268 
…es not exists, do not throw an exception, just start from the oldest message in cache dotnet#8863
@benjaminpetit benjaminpetit self-requested a review March 14, 2024 18:26
@ReubenBond
Copy link
Member

ReubenBond commented May 15, 2024 •
edited
Loading

@benjaminpetit PTAL and give this a more apt title for if/when we merge it
@ReubenBond
Copy link
Member

We might not have a lastPurged token for a stream if we restarted and began reading from the last checkpoint (see @benjaminpetit's comment here #8863 (comment)). I'll close this for now. Thank you for opening it!
@ReubenBond ReubenBond closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@gusuchengnan @ReubenBond @benjaminpetit