Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Recorded flag not propagated between activities #9016

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Fix for Recorded flag not propagated between activities #9016

merged 4 commits into from
Jul 8, 2024

Conversation

Costo
Copy link
Contributor

@Costo Costo commented May 21, 2024 •
edited by dotnet-policy-service bot
Loading

As discussed in #9011, create ActivityContext from traceparent and set isRemote: true to correctly propagate the Recorded flag.

Microsoft Reviewers: Open in CodeFlow
@ReubenBond ReubenBond self-assigned this May 22, 2024
@ReubenBond
Copy link
Member

ReubenBond commented May 22, 2024 •
edited
Loading

We need to fix the failing UnitTests.General.ActivityPropagationTests.WithParentActivity_Hierarchical test.
EDIT: closed accidentally
@ReubenBond ReubenBond closed this May 22, 2024
@ReubenBond ReubenBond reopened this May 22, 2024
@Costo
Copy link
Contributor Author

Costo commented Jun 4, 2024

I fixed the failing test.
@ReubenBond ReubenBond merged commit 4cfa850 into dotnet:main Jul 8, 2024
18 checks passed
@ReubenBond ReubenBond mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Costo @ReubenBond