Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add soname to shared library #109

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Add soname to shared library #109

merged 1 commit into from
Dec 9, 2023

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Dec 7, 2023

Fixes #107

@dougbinks
Copy link
Owner

Once again thanks for the issue #107 and this PR.

I have tested the PR on a variety of platforms and it works, though the versioning information is not set on the Windows DLL (using versioned DLLs on Windows is complex so I'm don't see this as an issue).

I'm going to consider this a bit more before deciding whether to merge, as it means I have to maintain the version number in the cmakelists.txt file.

@bkmgit
Copy link
Contributor Author

bkmgit commented Dec 7, 2023 via email

@dougbinks
Copy link
Owner

So far the methods I've seen to pull version number from Git history are fairly complicated, which goes against the 'lighweight' style of enkiTS. So it's only worth adding if it's simple to do.

@bkmgit
Copy link
Contributor Author

bkmgit commented Dec 7, 2023

git describe will get version information. Can add a GitHub action that would update the CMakeLists.txt file or a plain text VERSION file when needed. If a plain text VERSION file is used, CMake can read the version number from this.

@dougbinks
Copy link
Owner

That sounds like a good idea. I'll have a go at doing that.

@dougbinks dougbinks changed the base branch from master to dev December 9, 2023 15:44
@dougbinks dougbinks merged commit aef8969 into dougbinks:dev Dec 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants