Fix: Mark deprecated functions [[deprecated]] #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This additionally replaces usages of GetIsRunning with GetIsShutdownRequested, and exposes the latter in the C API.
|
Many thanks! I've merged this to pr-129 and updated that branch with a couple of changes. I'll test this and then merge to dev and main shortly. |
|
I've fully merged this to main/dev and deleted the pr-129 branch. Once again many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally replaces usages of
GetIsRunningwithGetIsShutdownRequested, and exposes the latter in the C API.Partially fixes #128. Note that this does add a fair share of warnings to the compile output, since the deprecated functions are used internally. I also added
enkiGetIsWaitforAllCalledfor the C API since it was referenced in the documentation as a replacement forenkiWaitforAll, which already existed, so that only seemed logical.