Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add language support: Traditional Chinese. #55

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

samuelchou
Copy link

@samuelchou samuelchou commented Dec 2, 2020

I'm trying to add Chinese(Traditional) support. It should be a easy fix...

@samuelchou
Copy link
Author

samuelchou commented Dec 10, 2020

@eggheadgames I'm just confused with the CircleCI error. How could I fix that? I'm willing to do the work. 💪

@mikemee
Copy link
Collaborator

mikemee commented Dec 11, 2020

@samuelchou Sorry for the slow response. My guess is that the CircleCi configuration needs to be updated for their version 2. I.e. similar to this change:

eggheadgames/android-about-box@127b89b#diff-f3e9d251e83fc546f51aa7cfc8ae605d64f20c232423c4b4eaf968f227b09ac6

If you have some time to do that, it is much appreciated!

@samuelchou
Copy link
Author

Interesting...CircleCI failed at.... uh, unexpectedly.

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine java version from '11.0.9.1'.

If that was what I think, gradle source seems to be out-dated...?

@samuelchou
Copy link
Author

samuelchou commented Dec 14, 2020

Ok...there are more gradle problems than I expected. I'll try to fix it by the way.

1: Task failed with an exception.
-----------
* What went wrong:
A problem occurred evaluating project ':library'.
> Failed to apply plugin [id 'com.github.dcendents.android-maven']
   > Could not create plugin of type 'AndroidMavenPlugin'.
      > Unable to determine constructor argument #1: missing parameter of type Factory, or no service of type Factory<LoggingManagerInternal>.
2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':library'.
> compileSdkVersion is not specified. Please add it to build.gradle
@samuelchou
Copy link
Author

samuelchou commented Dec 14, 2020

After I tried updating android-maven , problem shows up in Android Studio:

Caused by: org.gradle.api.plugins.UnknownPluginException: Plugin with id 'findbugs' not found.

And it seems that findbugs is removed, implying that all of the related codes need to be changed: https://stackoverflow.com/a/59102723/9735961

I don't know man, the fix seems like a HUGE work to the code, and it might be inappropriate to be done in this pull request...?
Please let me know if you have any thought @mikemee .

@samuelchou
Copy link
Author

samuelchou commented Dec 14, 2020

Since spotbugs wasn't function correctly, I just removed related codes temporarily to fix other problems. I can add it back if needed.
Also, I fix several bugs Circle CI detected. But bugs seem to be endless...

I now feel it's a disaster to upgrade gradle... 😭

@mikemee
Copy link
Collaborator

mikemee commented Dec 19, 2020

@samuelchou Sorry for the hassle. I went through most of this same stuff with the https://github.com/eggheadgames/android-about-box/ when I updated it to work with current versions of Android Studio and new releases of Android. There may be some clues there, as the projects were started around the same time and set up the same way.

Unfortunately, I don't use Siren in my Android apps any longer, so I wasn't forced to update it at the same time.

It looks like you're making steady progress. You might want to check the android-about-box project to see what version of Gradle I used there and also the upgrade PR: eggheadgames/android-about-box#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants