Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): cli capitalisation #3539

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix(cli): cli capitalisation #3539

merged 5 commits into from
Apr 12, 2024

Conversation

DevanceJ
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Fixes #3538
The cause of lowercase messages was automated help and version option message. I referred the commander.js docs and used
https://github.com/tj/commander.js?tab=readme-ov-file#helpoptionflags-description for help option and
https://github.com/tj/commander.js?tab=readme-ov-file#version-option for version option
@DevanceJ DevanceJ requested a review from a team as a code owner March 17, 2024 17:12
@erickzhao erickzhao self-requested a review March 18, 2024 16:19
@erickzhao erickzhao changed the title feat(cli): cli capitalisation Mar 18, 2024
@erickzhao erickzhao merged commit fc9af7c into electron:main Apr 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@DevanceJ @erickzhao