fix(maker-squirrel): only push delta
artifacts if they exist on disk
#3586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic here I think is wrong. It adds the
-delta
file toartifacts
even if it doesn't exist. This will cause--from-dry-run
to fail. I think electron installer might not always produce a delta file.Given the logic below for the
msi
that check the file exists before adding it, that made sense to do here to.