Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): protocol recognizes webpack's devServer setting #3650

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Dogdriip
Copy link
Contributor

@Dogdriip Dogdriip commented Jul 4, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

If you have opened your dev server with https via the devServer.server setting, make it aware of it.

@Dogdriip Dogdriip requested a review from a team as a code owner July 4, 2024 09:13
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, if we want to support https, should we support custom certificates (i.e., server.options)?

Ref: https://webpack.js.org/configuration/dev-server/#devserverserver

@Dogdriip
Copy link
Contributor Author

Dogdriip commented Jul 5, 2024

I have a question, if we want to support https, should we support custom certificates (i.e., server.options)?

Ref: webpack.js.org/configuration/dev-server

As the ref says, if we don't give it a certificate option, it will default to a self-signed certificate. If we use a custom certificate, I don't think there's anything forge needs to support.

@erickzhao erickzhao changed the title fix(WebpackConfig): protocol recognizes webpack's devServer setting Jul 9, 2024
@erickzhao erickzhao merged commit f0dd217 into electron:main Jul 9, 2024
12 checks passed
@Dogdriip Dogdriip deleted the Dogdriip-patch-1 branch July 10, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants