Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres Decimal division returns double precision #10418

Closed
GregoryTravis opened this issue Jul 1, 2024 · 4 comments · Fixed by #10479
Closed

Postgres Decimal division returns double precision #10418

GregoryTravis opened this issue Jul 1, 2024 · 4 comments · Fixed by #10479
Assignees
Labels
-libs Libraries: New libraries to be implemented p-low Low priority

Comments

@GregoryTravis
Copy link
Contributor

Decimal/Decimal returns double precision because the / operator always casts to double precision. This cast is presumably there so that integer division will be done as floating point division.

Instead of always casting to double precision, we should only do this if both arguments are integer types.

@GregoryTravis GregoryTravis added p-low Low priority -libs Libraries: New libraries to be implemented labels Jul 1, 2024
@GregoryTravis GregoryTravis self-assigned this Jul 1, 2024
@GregoryTravis GregoryTravis changed the title Postgres DECIMAL division returns DOUBLE PRECISION Jul 2, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 3, 2024

Greg Travis reports a new STANDUP for yesterday (2024-07-02):

Progress: in-memory and database backend arithmetic return types It should be finished by 2024-07-05.

Next Day: test failures

@enso-bot
Copy link

enso-bot bot commented Jul 3, 2024

Greg Travis reports a new STANDUP for today (2024-07-03):

Progress: discussing plan for arithmetic value/type consistency across backends; decimal division return types It should be finished by 2024-07-05.

Next Day: test failures

@enso-bot
Copy link

enso-bot bot commented Jul 5, 2024

Greg Travis reports a new 🔴 DELAY for today (2024-07-05):

Summary: There is 3 days delay in implementation of the Postgres Decimal division returns double precision (#10418) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: backend differences

@enso-bot
Copy link

enso-bot bot commented Jul 5, 2024

Greg Travis reports a new STANDUP for today (2024-07-05):

Progress: separating decimal tests into common and backend-specific, because of different handling of repeating decimals It should be finished by 2024-07-08.

Next Day: test failures

@GregoryTravis GregoryTravis linked a pull request Jul 8, 2024 that will close this issue
4 tasks
@mergify mergify bot closed this as completed in #10479 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented p-low Low priority
1 participant