Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning makes it impossible to open full screen viz with icon #10450

Closed
jdunkerley opened this issue Jul 5, 2024 · 2 comments · Fixed by #10546
Closed

Warning makes it impossible to open full screen viz with icon #10450

jdunkerley opened this issue Jul 5, 2024 · 2 comments · Fixed by #10546
Assignees
@farmaazon
Labels
--bug Type: bug -gui x-new-feature Type: new feature request
Milestone
2024-07 Release

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Jul 5, 2024 •
edited by AdRiley
Loading

Image

When the viz is open the warning/error should move down underneath it.

image
@jdunkerley jdunkerley added the -gui label Jul 5, 2024
@somebody1234
Copy link
Contributor

minor nit: it seems like the plus button is overlapping the output bar... perhaps the button should move down when that bar is visible?
@AdRiley AdRiley added x-new-feature Type: new feature request --bug Type: bug labels Jul 5, 2024
@AdRiley AdRiley added this to the 2024-07 Release milestone Jul 5, 2024
@farmaazon
Copy link
Contributor

minor nit: it seems like the plus button is overlapping the output bar... perhaps the button should move down when that bar is visible?

It's already fixed in #10443
@AdRiley AdRiley removed their assignment Jul 9, 2024
@farmaazon farmaazon self-assigned this Jul 12, 2024
@farmaazon farmaazon mentioned this issue Jul 12, 2024
Merged
3 tasks
mergify bot pushed a commit that referenced this issue Jul 13, 2024
@farmaazon
Move warning msg below viz (#10546)
bfb1d8e 
Fixes [10450](#10450)

![image](https://github.com/user-attachments/assets/21efe4e0-922b-4a83-8f6e-ddaea360e655)
@mergify mergify bot closed this as completed in #10546 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui x-new-feature Type: new feature request
4 participants
@AdRiley @farmaazon @somebody1234 @jdunkerley