Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to download from subfolders #10453

Open
somebody1234 opened this issue Jul 5, 2024 · 8 comments · Fixed by #10481
Open

Unable to download from subfolders #10453

somebody1234 opened this issue Jul 5, 2024 · 8 comments · Fixed by #10481
Assignees
@hubertp
Labels
-project-manager p-high Should be completed in the next sprint

Comments

@somebody1234
Copy link
Contributor

However, it seems that it does not support specifying the parent directory, which seems to break download functionality in nested folders on develop.
@somebody1234
Copy link
Contributor Author

pinging @4e6 as the author of the original PR
@somebody1234
Copy link
Contributor Author

oh, apparently it's been assigned to hubert
@hubertp hubertp self-assigned this Jul 5, 2024
@hubertp hubertp added the p-high Should be completed in the next sprint label Jul 5, 2024
@hubertp
Copy link
Contributor

hubertp commented Jul 5, 2024 •
edited by unfurl-links bot
Loading

As per discussion in the standup, this is currently defined in https://github.com/enso-org/enso/blob/develop/lib/scala/project-manager/src/main/scala/org/enso/projectmanager/infrastructure/http/ProjectsEndpoint.scala#L41

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
@enso-bot enso-bot bot mentioned this issue Jul 8, 2024
Open
@hubertp hubertp mentioned this issue Jul 10, 2024
Merged
4 tasks
@enso-bot
Copy link

enso-bot bot commented Jul 10, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-08):

Progress: Investigating logic behind project endpoint. Draft PR in place. Continued investigating startup logs. It should be finished by 2024-07-09.

Next Day: Next day I will be working on the #10453 task. Continue profiling startup.
@mergify mergify bot closed this as completed in #10481 Jul 11, 2024
@mergify mergify bot closed this as completed in 0ab9fe7 Jul 11, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 11, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-09):

Progress: Addressed review. Investigating regression in startup for #10503. Analyzed ongoing issues with cloud integration and filed #10495 as a blocker. It should be finished by 2024-07-09.

Next Day: Next day I will be working on the #10453 task. Continue profiling startup.
@hubertp hubertp reopened this Jul 12, 2024
@hubertp
Copy link
Contributor

hubertp commented Jul 12, 2024

@somebody1234 Can you check if the additional parameter unblocks you?
@somebody1234
Copy link
Contributor Author

somebody1234 commented Jul 12, 2024 •
edited by unfurl-links bot
Loading

@hubertp funny thing is, i was testing exactly this today and i can't get it to work on the latest nightly.
code is here: https://github.com/enso-org/enso/tree/wip/sb/dashboard-fixes - to test, download from subfolder on electron. you should be able to run npm run watch:linux (or macos/windows) in app/ide-desktop/lib/client to test electron without having to build the entire app

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.
@somebody1234
Copy link
Contributor Author

but yeah theoretically the additional parameter is enough
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-project-manager p-high Should be completed in the next sprint
3 participants
@hubertp @4e6 @somebody1234