Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output component inside collapsed components #10459

Closed
AdRiley opened this issue Jul 5, 2024 · 4 comments · Fixed by #10577
Closed

Improve output component inside collapsed components #10459

AdRiley opened this issue Jul 5, 2024 · 4 comments · Fixed by #10577
Assignees
Labels
-gui x-new-feature Type: new feature request

Comments

@AdRiley
Copy link
Member

AdRiley commented Jul 5, 2024

Today:

image

In future output component should be:

  • Marked as output
  • Always the last component in the code
  • Not deletable
@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Jul 5, 2024
@AdRiley AdRiley added this to the 2024-08 Release milestone Jul 5, 2024
@farmaazon
Copy link
Contributor

farmaazon commented Jul 5, 2024

Backlog refinement:

  • The second point is already implemented.
  • For now, let's treat it as "normal" node, just undeletable, and with some special icon and color.
  • And do not display variable name: just an icon to connect to.
  • Also, do not display output port in output node (you cannot drag edges from it anyway).
@farmaazon farmaazon self-assigned this Jul 12, 2024
@enso-bot
Copy link

enso-bot bot commented Jul 17, 2024

Adam Obuchowicz reports a new STANDUP for the last Monday (2024-07-15):

Progress: Implemented most of the features It should be finished by 2024-07-19.

Next Day: Next day I will be working on the same task. Finish and make PR (tests + single icon)

@enso-bot
Copy link

enso-bot bot commented Jul 17, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-07-16):

Progress: Finished features, but not tests. Also fixed flaky E2E tests It should be finished by 2024-07-19.

Next Day: Next day I will be working on the same task. Finish and make PR

@farmaazon farmaazon mentioned this issue Jul 17, 2024
4 tasks
@enso-bot
Copy link

enso-bot bot commented Jul 19, 2024

Adam Obuchowicz reports a new STANDUP for the last Wednesday (2024-07-17):

Progress: Added tests, and also one overlooked feature: output nodes cannot be collapsed. Created PR. It should be finished by 2024-07-19.

Next Day: Next day I will be working on the #9617 task. Start next task

@mergify mergify bot closed this as completed in #10577 Jul 19, 2024
@mergify mergify bot closed this as completed in 59f438e Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui x-new-feature Type: new feature request
2 participants