Update routing.md (#1397) #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crandmck
approved these changes
Apr 9, 2024
|
Thanks @chrisdel101 As far as other candidates, you can look at the other open issues or if you're confident of your knowledge of Express, comment on any of these PRs https://github.com/expressjs/expressjs.com/pulls?q=is%3Apr+is%3Aopen+label%3A%22needs+tech+review%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this was an easy fix. I'm not even sure if you wanted this "fixed," but it was more work to make the PR than the fix itself. Still, I made the PR anyway since I cloned the site locally.
PR: I only changed a single line 161. Anything else is white space or formatter releated
Totally fine to reject this. But please do not ignore it until auto-close
Let me know if you want help with other changes as I'm looking for tasks right now.