-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixed typos, spaces, and punctuation #1482
Conversation
Thanks for the PR @grjan7 Based on what I saw so far, this all looks OK, but I stopped at the edits to the So the files should be edited in each individual repo, not here. There is a notice at the top of each such page on the site:
We really should explain this somewhere, and it would be way better if it were done in a GitHub workflow instead of manually running a script. IAC, please remove these files from the PR, and then I'll continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove files in _includes/readmes
per comment.
Ok, @crandmck. |
@crandmck, I have removed those files from PR. You can review them now. |
@@ -120,9 +120,9 @@ app.listen(3000, () => { | |||
|
|||
[http-terminator](https://github.com/gajus/http-terminator) implements logic for gracefully terminating an express.js server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
terminating an Express server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Thanks again @grjan7. Corrections to spelling, punctuation, and formatting are valuable. Many of the edits in this PR simply removed extra spaces. I don't feel that adds a lot of value. It doesn't do any harm either, so I left them in this PR, but just for future reference. |
Thanks for your input, @crandmck. |
Fixes typos, spaces and punctuation.