Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused assets. #1493

Merged
merged 3 commits into from
Apr 23, 2024
Merged

removed unused assets. #1493

merged 3 commits into from
Apr 23, 2024

Conversation

MehfoozurRehman
Copy link
Contributor

according to the feedback on #1489 removed the unused assets
@MehfoozurRehman
Copy link
Contributor Author

and sorry for the inconvenience with the old pull request the vs code was asking me to fork the repo I already had forked so I deleted the fork and then forked again and that fixed it.
@crandmck
Copy link
Member

crandmck commented Apr 22, 2024 •
edited
Loading

Thanks @MehfoozurRehman ... I checked out the fork and ran it locally to make sure there were no issues, and it LGTM.

I just want to make sure that there's no reason to keep these file around that I'm not thinking of, so I've asked for another review from @jonchurch just to be sure.
sheplu
sheplu approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - did a quick check and it seems nothing is broken
@crandmck crandmck merged commit 8617b1c into expressjs:gh-pages Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@MehfoozurRehman @crandmck @sheplu @UlisesGascon