-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: removing BLM banner #1521
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah I didn't check the preview link, I just removed it based on looking at the original add commit. Maybe I missed something though or maybe some other change since caused it. I can look again later today. |
I had merged something to tweak CSS to accommodate the banner years ago. Likely that is the root of the navbar issue. Glad to see this PR though, had been meaning to make this. Wes and I helped land this originally (TJ coded and merged it in iirc, and we both voted in support), so appropriate to be involved in removing it. For reference, this came in in 2020 when several major sites added a banner. React kept theirs up for approx 4 months before removing it. We never came back to remove ours while express' website slumbered, the world was rocked by covid, folks were burnt out, and the US was going through a host of its own issues. After having it up for 4 years, much longer than any other major doc site kept theirs, we can remove the banner. |
Not sure I ever looked at the code for the website, this is some old school layout css 🥇. I pushed a change. Not sure if it is the exact right one, but it seemed to fix the odd spacing left over after removing the banner. |
Thanks for doing this @wesleytodd ... IMO one big issue with this banner was that it linked to (and thus promoted) one particular organization/charity. Although it is of course a worthy one, there are literally hundreds of others, and this begs the question of why we are promoting this one rather than any other one. Although I don't think this was the case, it could lead to questions of favoritism or impropriety. Also, the change was originally made in contravention of the contribution guidelines, i.e. in a force push, not a PR: daeac13 Anyway, LGTM. |
Hopefully no one will mind if I go ahead and land this. Since this touches quite a few files, I want to avoid potential merge conflicts with other PRs. |
We discussed this on a meeting a while back and I think we agreed it was time to take down this banner. To be very clear to anyone seeing this, this removal is not a political statement. This project and folks who contribute to it are very much in support of the message and believe in the broader goal of an equitable justice system.