C Bindings

[parkerstafford]

Review for Kam

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (6168ad9) to head (1cd49fd).
Report is 12 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         103      103           
  Lines        7701     7707    +6     
=======================================
+ Hits         7438     7444    +6     
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mwestphal]

FYI @Meakk

[github-actions]

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: python, java, webassembly.

[mwestphal]

A few warnings and errors to fix in CI:

 cc1: warning: command-line option '-Woverloaded-virtual' is valid for C++/ObjC++ but not for C
cc1: error: command-line option '-Wsuggest-override' is valid for C++/ObjC++ but not for C [-Werror]
In file included from /__w/f3d/f3d/source/f3d/library/public/image.h:4,
                 from /__w/f3d/f3d/source/f3d/library/src/image_c_api.c:2:
/__w/f3d/f3d/source/f3d/library/public/exception.h:4:10: fatal error: stdexcept: No such file or directory
    4 | #include <stdexcept>
      |          ^~~~~~~~~~~
cc1: all warnings being treated a

But it looks good so far!

[mwestphal]

is this file compiled ?

[Meakk]

It does not seem so, it needs to be added in library/testing/CMakeLists.txt

[Meakk]

It does not seem so, it needs to be added in library/testing/CMakeLists.txt

[Meakk]

I think this file (which includes and uses image.h) must be a C++ file. Only image_c_api.h have to be C only (and the unit test of course).

[mwestphal]

hey @parkerstafford , need any help moving forward ?