Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal screenshot #1523

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Minimal screenshot #1523

merged 3 commits into from
Jul 8, 2024

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Jul 7, 2024

Allow saving "minimal"/"clean" screenshots with transparent background and no grid or overlays, as requested by a user on Discord.
Bound to F11 instead of the initially proposed shift+F12 because of current technical limitations.

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (0e0b9b0) to head (d0ecaaa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1523   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files         105      105           
  Lines        7831     7844   +13     
=======================================
+ Hits         7579     7592   +13     
  Misses        252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwestphal
Copy link
Contributor

Not sure why CI is not clean, that looks like a missing DEFAULT_LIGHTS, but afair your screenshot testing mechanism should not require it ?

@snoyer
Copy link
Contributor Author

snoyer commented Jul 8, 2024

Not sure why CI is not clean, that looks like a missing DEFAULT_LIGHTS, but afair your screenshot testing mechanism should not require it ?

Good point, it does compare the screenshot to a render so I'll add DEFAULT_LIGHTS. The question is more why hasn't it needed it before

@mwestphal
Copy link
Contributor

Yeah, I'm a bit confused here too. That being said, the image comparison algorithm is not great and can have false negative.

We plan to update it soon.

@mwestphal mwestphal merged commit 0c479dd into f3d-app:master Jul 8, 2024
41 checks passed
@snoyer snoyer deleted the minimal-screenshot branch July 8, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants