Do not allow consider an account connected if IDP says so #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbiesinger
reviewed
Nov 15, 2023
|
@bvandersloot-mozilla FYI about this editorial but fairly trivial spec bug fix. I'll look to see if we need to add WPT coverage for this or if there is already. |
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Nov 16, 2023
SHA: 8253c9f Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we fix the case where an account has been observed to be connected in the past by the user agent, but the IdP explicitly says that this account is not connected via approved_clients. This could happen if a user has revoked the federated account, and so the IdP information should be respected. In other words, if
approved_clientsis present and implies that the account is not connected, the user agent should consider it to be disconnected.Preview | Diff