Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to RFC9110 #520

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Update links to RFC9110 #520

merged 2 commits into from
Dec 1, 2023

Conversation

tidoust
Copy link
Contributor

@tidoust tidoust commented Nov 24, 2023

We rolled back on the change introduced in #452 and now use the more readable httpwg.org version of RFC9110 to populate the cross-references database. We also updated Specref to return the httpwg.org URL for that spec.

This means that the cross-references database no longer has the section IDs and rather has the field name. This update rolls back the changes in #452 accordingly.


Preview | Diff

We rolled back on the change introduced in fedidcg#452 and now use the more
readable `httpwg.org` version of RFC9110 to populate the cross-references
database. We also updated Specref to return the `httpwg.org` URL for that
spec.

This means that the cross-references database no longer has the section IDs
and rather has the field name. This update rolls back the changes in fedidcg#452
accordingly.
@npm1
Copy link
Collaborator

npm1 commented Nov 24, 2023

Thanks for the change! But in the Preview I do not see these being linked, any idea why?

@tidoust
Copy link
Contributor Author

tidoust commented Nov 24, 2023

Hmm, I don't really know. The update to Bikeshed data that brought the new fragment identifiers was ~30mn ago. Could it be that the new data has not yet propagated to PR Preview?

@tidoust
Copy link
Contributor Author

tidoust commented Nov 24, 2023

More precisely, I think PR preview uses the online version of Bikeshed which does not yet seem to have the latest data. I guess I was too fast for once ;)

I think that the spec-prod action fetches the latest version of Bikeshed and of Bikeshed data, but I haven't checked, so you may want to wait a bit before you merge the PR.

Copy link
Collaborator

@npm1 npm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok approving for now but we can wait a bit before merging

@npm1
Copy link
Collaborator

npm1 commented Nov 29, 2023

Could you resolve merge conflicts and then we can merge this?

@npm1 npm1 merged commit fd85feb into fedidcg:main Dec 1, 2023
2 checks passed
github-actions bot added a commit that referenced this pull request Dec 1, 2023
SHA: fd85feb
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants