Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: density-based point size #143

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: density-based point size #143

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3bec1dc
Initial working density-based point size
flekschas May 1, 2023
3811756
Adjust the hover rendering
flekschas May 29, 2023
ff67faa
Fix relative point offset
flekschas May 30, 2023
fc88469
Fix selected point outline width
flekschas May 30, 2023
1d42cbd
Merge branch 'master' into density-based-point-size
flekschas Jul 4, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix selected point outline width
  • Loading branch information
@flekschas
flekschas committed May 30, 2023
commit fc884698aa318ff342829f9aa75bbbdadbdcdb3b
8 changes: 6 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1703,7 +1703,9 @@ const createScatterplot = (
};

const drawSelectedPointOutlines = drawPoints(
() => (pointSizeSelected + pointOutlineWidth * 2) * window.devicePixelRatio,
() =>
(pointSizeSelected + (pointOutlineWidth / camera.scaling[0]) * 2) *
window.devicePixelRatio,
getSelectedNumPoints,
getSelectedPointsIndexBuffer,
COLOR_ACTIVE_IDX,
Expand All @@ -1712,7 +1714,9 @@ const createScatterplot = (
);

const drawSelectedPointInnerBorder = drawPoints(
() => (pointSizeSelected + pointOutlineWidth) * window.devicePixelRatio,
() =>
(pointSizeSelected + pointOutlineWidth / camera.scaling[0]) *
window.devicePixelRatio,
getSelectedNumPoints,
getSelectedPointsIndexBuffer,
COLOR_BG_IDX,
Expand Down