Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR 1106 GroupedRadio separator behavior to GroupedCheckbox #1346

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Add PR 1106 GroupedRadio separator behavior to GroupedCheckbox #1346

merged 3 commits into from
Dec 28, 2023

Conversation

freemansoft
Copy link
Contributor

Connection with issue(s)

Close #1345

Connected to #???

Solution description

  1. Copied GroupedRadio separator behavior into GroupedCheckbox.
  2. Added to example app.
  3. There was no test of the GroupedRadio behavior so don't know if you want a test.

Screenshots or Videos

flutter-grouped-radio-checkbox-divider-sync

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • [] Add unit test to verify new or fixed behavior
  • If apply, add documentation to code properties and package readme
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66d87f0) 87.03% compared to head (caa0699) 87.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1346      +/-   ##
==========================================
+ Coverage   87.03%   87.71%   +0.68%     
==========================================
  Files          21       21              
  Lines         748      757       +9     
==========================================
+ Hits          651      664      +13     
+ Misses         97       93       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@deandreamatias deandreamatias merged commit 7f542eb into flutter-form-builder-ecosystem:main Dec 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@freemansoft @deandreamatias