RequireJS optimization doesn't correctly detect define method in i18n.js #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fine method in i18n.js
|
Can you run test added in #311? |
|
Both the spec.html file and spec_requirejs.html file run without errors: spec.html: spec_requirejs.html |
PikachuEXE
added a commit
that referenced
this pull request
Mar 13, 2015
RequireJS optimization doesn't correctly detect define method in i18n.js
|
Really need some automatic test for this kind of stuff Q_Q |
|
@thegillis |
|
I am gonna assume it's working fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example fix for bug #314.