Transform comparison #237
Merged
Transform comparison #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Types implementing ITransform don't override equality methods, so using them in FuncUI means reassignments on every view generation (if caching is not possible). And such reassignment means additional layout/redraw pass.
JordanMarr
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided a custom equality comparer for types implementing the
ITransforminterface.Types implementing the
ITransformdon't override equality methods, so using them in FuncUI means reassignments on every view generation (if transforms are created on the fly instead of reusing the same instance, producing an object not equal to the previous one even if it's created with the same constructor arguments as defaultEqualscompares references). And such reassignment means an additional layout/redraw pass.