Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data grid bindings #289

Merged
merged 2 commits into from
Apr 5, 2023
Merged

data grid bindings #289

merged 2 commits into from
Apr 5, 2023

Conversation

JaggerJo
Copy link
Member

@JaggerJo JaggerJo commented Apr 2, 2023

No description provided.

@JaggerJo JaggerJo changed the title data grid prove of concept Apr 2, 2023
JordanMarr
JordanMarr approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@JordanMarr JordanMarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! A much needed addition. 👍
@JaggerJo
Copy link
Member Author

JaggerJo commented Apr 2, 2023 •
edited
Loading

Yeah, it's about time 😄

The bindings aren't complete yet - Avalonia even crashes when double clicking a text cell 😅

Adding the bindings to the current project also means adding a reference to Avalonia.Controls.DataGrid.
@Numpsy
Copy link
Collaborator

Numpsy commented Apr 2, 2023

Adding the bindings to the current project also means adding a reference to Avalonia.Controls.DataGrid

We do at least seem to be getting to a point where the linker trimming machinery can remove the extra libraries at build time if they aren't actually being called :-)
@JordanMarr
Copy link
Collaborator

Yeah, it's about time 😄

The bindings aren't complete yet - Avalonia even crashes when double clicking a text cell 😅

Interesting... it doesn't crash for me when I double click the text cell. 🤷‍♂️

Adding the bindings to the current project also means adding a reference to Avalonia.Controls.DataGrid.

That seems ok to me since the DataGrid is such a commonly used control in most projects.
@JaggerJo JaggerJo merged commit bf56f4f into master Apr 5, 2023
@JaggerJo JaggerJo deleted the data-grid-bindings branch April 5, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@JaggerJo @Numpsy @JordanMarr