Drag and Drop functionality #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may expose a bug in Avalonia.FuncUI. As soon as you press the mouse button on Drag Me you get two PressedPointerEvents. This makes certain cases not work properly. For example, 1. When you immediately release the button you do not get a DragDropEffects.None cancellation response. 2. If you drag it to the drop target, you get a count of 1 the first time and n + 2 for each subsequent attempt. If you look at the output in the terminal you can see the multiple messages being triggered and how the display and state do not match.
This is an ugly hack to work around the fact that we get to PointerPressedEvents when the user presses the mouse button over the drag source. It should be reverted or removed once that is fixed.
Marks the event as handled avoiding the ugly hack of tracking drag state in the model. The remaining bug is that occassionally we get a Dragged message without receiving a Dropped message. The Dragged message is fired by completion of the doDrag Async. I assume that is why we always get one. However the Dropped message is dispatched from the drop target's onDrop handler. It is possible that this is responsible for the difference. I tried adding diagnostics to the onDrop handler to see if it was receiving and unexpected data type that is not being handled, but it is not even being called.
Numpsy
force-pushed
the
rw/dragdrop_rebase
branch
from
ca36426
to
f9e3545
Compare
|
Rebase on top of the current code, to make sure there's no issues with the new Avalonia 11 previews |
|
LGTM, should I merge? |
|
The demo in the control catalog does seem to be working ok with the latest code. (I was previously intending to try adding drop-drop file opening to a tool I was working on that would use this, but I've been snowed under with other things and haven't got to it yet :-( ) |
|
I tried plugging it into a test app and it works sufficiently to open a file via drag and drop, so the base functionality looks good :-)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the changes from #130 plus