Adding more Color overloads for brush properties #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mics Some Controls already allowed to set brush properties with Color directly while others only had color: string This adds such overloads where they were missing
Renaming could potentially break code using named parameters, however with only one parameter such usage seems unlikely
JaggerJo
approved these changes
Oct 30, 2023
|
It would surprise me if the parameter names were used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: Some properties had overloads taking a Color value in addition to IBrush and a color string.
This commit adds overloads for brush properties missing a Color overload making it more consistent and ergonomic since at least in my mind setting the brush to a solid color is probably the most common scenario.
I was tempted to also change the parameter names in some cases where they are the generic term "value" to "color"/"brush" but then refrained since it could possibly break someone's code if they use named parameters and also not sure what you think of such a change.