Use inferred timezone for time field in output #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for sharing. Please implement this as a new field rather than losing the existing field. Maybe the new field can be time_local. |
|
Done! |
|
Yup, that looks great, thank you! |
|
Released version 3.2.0. I'm not sure how our version gets bumped in Homebrew. Somebody else did this last time, possibly automatically, and I don't see documentation of how that works. |
|
Awesome, thank you, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since an inferred timezone is returned as part of the placemark data, it can be used to localize the timestamp string given in the JSON blob, as well as the string data (if
requiresPlaceMarkLookupis toggled on as the result of one of the other format specifiers).This PR just alters the
timefield (in both the JSON output and the formatted string output) to use the user's inferred timezone if available – it outputs in exactly the same format as the default, but will use the correct timezone instead of UTC. If this isn't available, it falls back to UTC (the existing behavior).