Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support @import from TypeScript 5.5 #1218

Closed
turadg opened this issue Mar 27, 2024 · 1 comment · Fixed by #1219 · May be fixed by junsulee/juice-shop#4
Closed

support @import from TypeScript 5.5 #1218

turadg opened this issue Mar 27, 2024 · 1 comment · Fixed by #1219 · May be fixed by junsulee/juice-shop#4
Labels

Comments

@turadg
Copy link

turadg commented Mar 27, 2024

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch eslint-plugin-jsdoc@47.0.2 for the project I'm working on.

We used the TypeScript 5.5 nightly to get microsoft/TypeScript#57207. That caused this linter to report an invalid tag.

Here's a fix to include the @import tag in typescript mode.

diff --git a/node_modules/eslint-plugin-jsdoc/dist/tagNames.js b/node_modules/eslint-plugin-jsdoc/dist/tagNames.js
index 4d27508..2d9aeb5 100644
--- a/node_modules/eslint-plugin-jsdoc/dist/tagNames.js
+++ b/node_modules/eslint-plugin-jsdoc/dist/tagNames.js
@@ -102,6 +102,8 @@ const jsdocTags = exports.jsdocTags = {
  */
 const typeScriptTags = exports.typeScriptTags = {
   ...jsdocTags,
+  // https://github.com/microsoft/TypeScript/issues/22160
+  import: [],
   // https://www.typescriptlang.org/tsconfig/#stripInternal
   internal: [],
   // https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#overload-support-in-jsdoc

I can make a PR if you like.

brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this issue Mar 28, 2024
brettz9 added a commit that referenced this issue Mar 28, 2024
Copy link

🎉 This issue has been resolved in version 48.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

turadg added a commit to Agoric/agoric-sdk that referenced this issue Mar 28, 2024
turadg added a commit to Agoric/agoric-sdk that referenced this issue Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant