Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify data projection not compatible / available for COG #9589

Closed
1 of 6 tasks
Tracked by #9593
offtherailz opened this issue Oct 12, 2023 · 2 comments · Fixed by #9690, #9717, #9736 or #9769
Closed
1 of 6 tasks
Tracked by #9593

Notify data projection not compatible / available for COG #9589

offtherailz opened this issue Oct 12, 2023 · 2 comments · Fixed by #9690, #9717, #9736 or #9769

Comments

@offtherailz
Copy link
Member

offtherailz commented Oct 12, 2023

Description

When the download metadata is checked (and it should be by default), we have to check the CRS and notify the user if the CRS definiton is not defined in MapStore, so the layer can not be reporojected in the map CRS.

CRS should be avaliable from const crs = getProjectionFromGeoKeys(image); we already query on catalog to get the BBOX

Also if the layer in map is in a projection not compatible, it should be grayed out and notified as for WMTS.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

I don't think is relevant for our implementation,
but we noticed that in this example openlayer do not define any projection for the map or include the tiff projection

https://openlayers.org/en/latest/examples/cog.html

Probably the OL map has some automation to properly target projection

Instead here they are defined

https://openlayers.org/en/latest/examples/multiple-cogs.html

@tdipisa tdipisa changed the title Notify data projection not compatible / avaliable for COG Oct 12, 2023
@tdipisa tdipisa mentioned this issue Oct 12, 2023
6 tasks
@tdipisa tdipisa added this to the 2023.02.01 milestone Oct 12, 2023
@tdipisa tdipisa assigned dsuren1 and unassigned tdipisa Nov 3, 2023
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 3, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Nov 6, 2023

@offtherailz

Existing

If I'm not wrong, currently only warning notification is shown when the layer is not compatible and added from catalog
image

And catalog panel shows something like this when the selected crs is not compatible for WMS/WMTS and prevents the layer from being added, but the layer is not disabled/greyed out after added to TOC panel. Maybe this needs to be implemented for all layers.
image

Clarification

Kindly clarify. So as part of this issue, when COG layer crs is not defined in MS and added from catalog, we display the warning notification and gray out the layer. This is applicable only for COG layer

@dsuren1
Copy link
Contributor

dsuren1 commented Nov 7, 2023

@tdipisa @offtherailz

Updated acceptance criteria

  • Restrict user from adding the cog layer when incompatible (just like with WMTS/WMS)
  • Show a warning when the layer is already added and reloaded/recreated (imported map etc)
  • Show a error on the toc layer node with a tooltip on the info icon The layer's source data projection definition (${sourceCRS}) is not available in the application for reprojecting the data in the current map
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 10, 2023
@dsuren1 dsuren1 linked a pull request Nov 10, 2023 that will close this issue
5 tasks
@ElenaGallo ElenaGallo assigned tdipisa and ElenaGallo and unassigned tdipisa Nov 20, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 21, 2023
offtherailz pushed a commit that referenced this issue Nov 21, 2023
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 21, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 23, 2023
@dsuren1 dsuren1 linked a pull request Nov 23, 2023 that will close this issue
5 tasks
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Nov 29, 2023
tdipisa pushed a commit that referenced this issue Nov 29, 2023
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment