Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For 3D tiles, the whole catalog component crashes when a status code of type 40X is returned from the server, provide better exception handling #9821

Closed
1 task done
mahmoudadel54 opened this issue Dec 18, 2023 · 0 comments · Fixed by #9844 or #9854
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C027-COMUNE_FI-2023-SUPPORT
Milestone

Comments

@mahmoudadel54
Copy link
Collaborator

mahmoudadel54 commented Dec 18, 2023

Description

If a 3dTiles layer record coming a CSW catalog, and it gives an error like below, the catalog should still show the available 3D Tiles

firenze.mp4

Current Result

  • Whenver a CWS record with a 3dTiles resource URL, (with the relative .json describing file for the 3dtile model) is found <dc:URI> in the <csw> record, mapstore starts parsing the .json file.
  • If the content of the file is not parsable as json (see in the example the 403 request returns an error in XML format) this crashes the whole catalog component and it will be not possible to scroll through the catalog pages, only the error message is visible.

Expected Result

  • Whenver a CWS record with a 3dTiles resource URL, (with the relative .json describing file for the 3dtile model) is found <dc:URI> in the <csw> record, mapstore starts parsing the .json file.
  • If the content of the file is not parsable as json, the exception should be handled gracefully, either not displaying the layer ITEM or graying the item out and not making it possible to add the layer to the map. The whole catalog component should not crash and it will still be possible to scroll through the catalog pages, with no error visible general error messages.

Current Result

An error occurs:

There was an error loading data

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@mahmoudadel54 mahmoudadel54 self-assigned this Dec 18, 2023
@tdipisa tdipisa assigned MV88 and unassigned mahmoudadel54 Dec 18, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Dec 20, 2023
@tdipisa tdipisa added this to the 2023.02.02 milestone Dec 20, 2023
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 20, 2023
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 8, 2024
@tdipisa tdipisa added the 3D All issues related to the 3D rendering in CesiumJs label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C027-COMUNE_FI-2023-SUPPORT
4 participants