Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Binary dashboard public dashboard have + button #9932

Closed
1 task done
offtherailz opened this issue Jan 30, 2024 · 0 comments · Fixed by #10277 or #10297
Closed
1 task done

On Binary dashboard public dashboard have + button #9932

offtherailz opened this issue Jan 30, 2024 · 0 comments · Fixed by #10277 or #10297
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted bug Good first issue Internal
Milestone
2024.01.01

Comments

@offtherailz
Copy link
Member

offtherailz commented Jan 30, 2024 •
edited
Loading

Description

As mentioned on this mapstore users mailing list message we verified that the binary (2023.02.xx) for some reason shows the "+" buttons to users that are not authenticated. This doesn't happen on dev, qa or stable servers.
We have to verify if this problem is still present of 2024.01.xx and if so fix it.
This issue has been verified by @tdipisa on 2023.02.01

How to reproduce

  • Download binary an start it
  • Login as admin
  • Create a public (everyone can view) dashboard).
  • Logout
  • Open the dashboard as anonymous user

Expected Result
The dashboard should be read-only.

Current Result
The + button is present

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@offtherailz offtherailz added this to the 2024.01.00 milestone Jan 30, 2024
@offtherailz offtherailz changed the title On Binary dashboard Jan 30, 2024
@tdipisa tdipisa modified the milestones: 2024.01.00, 2024.01.01 Feb 27, 2024
@tdipisa tdipisa added Internal BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Apr 24, 2024
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Apr 24, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 6, 2024
@mahmoudadel54
geosolutions-it#9932: On Binary dashboard public dashboard have + button
8e2d4ef 
Description:
- fix showing add dashboard button for guest users
@mahmoudadel54 mahmoudadel54 mentioned this issue May 6, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request May 6, 2024 that will close this issue
#9932: On Binary dashboard public dashboard have + button #10277
Merged
12 tasks
offtherailz pushed a commit that referenced this issue May 6, 2024
@mahmoudadel54
#9932: On Binary dashboard public dashboard have + button (#10277)
a3dfe06
@ElenaGallo ElenaGallo self-assigned this May 7, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 9, 2024
@mahmoudadel54
geosolutions-it#9932: On Binary dashboard public dashboard have + but…
e990a7a 
…ton (geosolutions-it#10277)
@mahmoudadel54 mahmoudadel54 mentioned this issue May 9, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request May 9, 2024 that will close this issue
[Backport 2024.01.xx] #9932: On Binary dashboard public dashboard have + button (#10277) #10297
Merged
tdipisa pushed a commit that referenced this issue May 10, 2024
@mahmoudadel54
#9932: On Binary dashboard public dashboard have + button (#10277) (#…
a6766d1 
…10297)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted bug Good first issue Internal
4 participants
@offtherailz @tdipisa @ElenaGallo @mahmoudadel54