#10026: fix functional tests for Interactive legend for TOC layers [WMS Support] #10249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port] Description: - fix functional tests for interactive legend geosolutions-it#10026
mahmoudadel54
added
New Feature
6 tasks
…port] Description: - fix import mistake in TOCItemsSettings file
allyoucanmap
requested changes
Apr 24, 2024
web/client/components/TOC/fragments/settings/__tests__/Display-test.jsx
Outdated
Show resolved
Hide resolved
…port] Description: - resolve review comments by adding a configration prop for TOCItemsSettings 'hideInteractiveLegendOption' - remove the replaced selector 'isMapOnlyOpenedSelector' - edit unit test of 'Display-test' file -
…port] Description: - revert the change in map.js in selectors
allyoucanmap
approved these changes
Apr 24, 2024
|
@ElenaGallo please test on dev and let us know for the backport, thanks. |
|
Test passed |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes fixing functional tests for interactive legend #10026:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10026
What is the current behavior?
Saving map with a layer that has a flag of enabling interactive legend to keep it in each open this map was not working well.
Dashboard and geostory were containing the checkbox of enabling interactive legend in Display tab in layer settings.
What is the new behavior?
Save map is handling storing the enable interactive legend flag to keep it stored if user close the map and open it again.
For dashboard and geostory pages, the enable interactive legend checkbox in layer settings in Display tab is hidden now.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information