#10279: Show credits/attribution text in printed page #10451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - add credit layer values to print configration object to send it to the server - create a util function to parse credit text by removing tags and | symbol - edit config.yaml of print - add migration guide - add unit test
mahmoudadel54
added
New Feature
14 tasks
MV88
added
the
BackportNeeded
MV88
requested changes
Jul 5, 2024
There was a problem hiding this comment.
@mahmoudadel54
Please checkout my comments.
There are needed a few changes here and there
…w comments) Description: - add PR link to migration guide file for the added section - add js doc to 'parseCreditRemovingTagsOrSymbol' method - simplified the method of 'getLayersCredits'
…w comments) Description: - edit clear phrase migration guide file for the added section - fix FE test for the simplified the method of 'getLayersCredits'
MV88
approved these changes
Jul 5, 2024
MV88
approved these changes
Jul 5, 2024
|
@ElenaGallo please test it in DEV |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jul 8, 2024
…eosolutions-it#10451) * geosolutions-it#10279: Show credits/attribution text in printed page Description: - add credit layer values to print configuration object to send it to the server - create a util function to parse credit text by removing tags and | symbol - edit config.yaml of print - add migration guide - add unit test
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Jul 8, 2024
* #10279: Show credits/attribution text in printed page Description: - add credit layer values to print configuration object to send it to the server - create a util function to parse credit text by removing tags and | symbol - edit config.yaml of print - add migration guide - add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, adding credit/attribution section to print map is enabled by adding a new section into config.yaml of print.
Now in print map, the attribution section will be displayed if the map has layers with credit titles [attributions].
Update the config.yaml file is required if attribution/credit section is need to added.
This PR includes also migration guide for this.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10279
What is the current behavior?
#10279
What is the new behavior?
The credits/attributions text will be displayed in printed page.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information