Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8578 SEARCH_WITH_FILTER action: add popup support #8673

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
#8575 SEARCH_WITH_FILTER action: add popup support
  • Loading branch information
belom88 committed Oct 10, 2022
commit 2d384f9e5d171e1293eccd6d6d2ef24cf0e52e09
30 changes: 30 additions & 0 deletions web/client/epics/__tests__/search-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ const STATE_NAME = 'STATE_NAME';

import { testEpic, addTimeoutEpic, TEST_TIMEOUT } from './epicTestUtils';
import {addLayer} from "../../actions/layers";
import { ADD_MAP_POPUP } from '../../actions/mapPopups';

const nestedService = {
nestedPlaceholder: TEST_NESTED_PLACEHOLDER
Expand Down Expand Up @@ -609,6 +610,35 @@ describe('search Epics', () => {
done();
}, {layers: {flat: [{name: "layerName", url: "base/web/client/test-resources/wms/GetFeature.json", visibility: true, queryable: true, type: "wms"}]}});
});
it('searchOnStartEpic, that adds popup', (done) => {
const testStore = {
mapInfo: {showInMapPopup: true},
layers: {
flat: [
{
name: "layerName",
url: "base/web/client/test-resources/wms/GetFeature.json",
visibility: true,
queryable: true,
type: "wms"
}
]
}
};
let action = searchLayerWithFilter({layer: "layerName", cql_filter: "cql"});
const NUM_ACTIONS = 3;
testEpic(searchOnStartEpic, NUM_ACTIONS, action, (actions) => {
expect(actions).toExist();
expect(actions.length).toBe(NUM_ACTIONS);
expect(actions[0].type).toBe(FEATURE_INFO_CLICK);
expect(actions[1].type).toBe(SHOW_MAPINFO_MARKER);
const popupAction = actions[2];
expect(popupAction.type).toBe(ADD_MAP_POPUP);
expect(popupAction.popup?.position?.coordinates?.[0]).toBe(968346.2286324208);
expect(popupAction.popup?.position?.coordinates?.[1]).toBe(5538315.133325616);
done();
}, testStore);
});
it('textSearchShowGFIEpic, it sends info format taken from layer', (done) => {
let action = showGFI(
{
Expand Down
14 changes: 11 additions & 3 deletions web/client/epics/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import toBbox from 'turf-bbox';
import pointOnSurface from '@turf/point-on-surface';
import assign from 'object-assign';
import {isNil, sortBy} from 'lodash';
import uuid from 'uuid';

import {centerToMarkerSelector, getLayerFromName, queryableLayersSelector} from '../selectors/layers';

Expand Down Expand Up @@ -44,14 +45,16 @@ import {
ZOOM_ADD_POINT
} from '../actions/search';

import CoordinatesUtils from '../utils/CoordinatesUtils';
import CoordinatesUtils, { reproject } from '../utils/CoordinatesUtils';
import {defaultIconStyle, layerIsVisibleForGFI, showGFIForService} from '../utils/SearchUtils';
import {generateTemplateString} from '../utils/TemplateUtils';

import {API} from '../api/searchText';
import {getFeatureSimple} from '../api/WFS';
import {getDefaultInfoFormatValueFromLayer} from '../utils/MapInfoUtils';
import {identifyOptionsSelector} from '../selectors/mapInfo';
import {identifyOptionsSelector, isMapPopup} from '../selectors/mapInfo';
import { addPopup } from '../actions/mapPopups';
import { IDENTIFY_POPUP } from '../components/map/popups';

const getInfoFormat = (layerObj, state) => getDefaultInfoFormatValueFromLayer(layerObj, {...identifyOptionsSelector(state)});

Expand Down Expand Up @@ -321,9 +324,14 @@ export const searchOnStartEpic = (action$, store) =>
.switchMap(({ type, geometry, typeName }) => {
let coord = pointOnSurface({ type, geometry }).geometry.coordinates;
const latlng = {lng: coord[0], lat: coord[1] };
const {x, y} = reproject(coord, 'EPSG:4326', 'EPSG:3857');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current map could have a different projection from EPSG:3857 so please use projectionSelector from the map selectors to get the correct one


if (coord) { // trigger get feature info
return Rx.Observable.of(featureInfoClick({latlng}, typeName, [typeName], {[typeName]: {cql_filter: cqlFilter}}), showMapinfoMarker());
return Rx.Observable.of(featureInfoClick({latlng}, typeName, [typeName], {[typeName]: {cql_filter: cqlFilter}}), showMapinfoMarker())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a marker on the map after closing the popup and this is due to the showMapinfoMarker() action.
We should avoid to dispatch showMapinfoMarker if the isMapPopup is true bacause the marker should be hidden, the popup is already showing the position.

marker-popup-bug.mp4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it's better to hide the marker when we use popup display option.

.merge(Rx.Observable.of(addPopup(uuid(),
{component: IDENTIFY_POPUP, maxWidth: 600, position: {coordinates: [x, y]}}))
.filter(() => isMapPopup(store.getState()))
);
}
return Rx.Observable.empty();
}).catch(() => {
Expand Down