Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8959 Add hide options for service selector of LayerDownload plugin #8960

Merged
merged 1 commit into from
Feb 14, 2023
Merged

#8959 Add hide options for service selector of LayerDownload plugin #8960

merged 1 commit into from
Feb 14, 2023

Conversation

allyoucanmap
Copy link
Contributor

@allyoucanmap allyoucanmap commented Feb 13, 2023 •
edited
Loading

Description

This PR adds the cfg hideServiceSelector option for the LayerDownload plugin to hide the service selector input

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#8959

What is the new behavior?

A new hideServiceSelector option for the LayerDownload plugin to hide the service selector field

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information
@allyoucanmap allyoucanmap added this to the 2023.01.00 milestone Feb 13, 2023
@allyoucanmap allyoucanmap self-assigned this Feb 13, 2023
@allyoucanmap allyoucanmap linked an issue Feb 13, 2023 that may be closed by this pull request
Add hide options for service selector of LayerDownload plugin #8959
Closed
1 task
@tdipisa tdipisa requested a review from dsuren1 February 13, 2023 16:12
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Feb 13, 2023
dsuren1
dsuren1 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@dsuren1 dsuren1 merged commit e5f30cd into geosolutions-it:master Feb 14, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Feb 14, 2023

Hi @ElenaGallo Kindly test it in dev. Thanks!
@ElenaGallo
Copy link
Contributor

Test passed on dev, can be backported.
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request Feb 17, 2023
@allyoucanmap
geosolutions-it#8959 Add hide options for service selector of LayerDo…
7af57dc 
…wnload plugin (geosolutions-it#8960)
@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Feb 17, 2023
@tdipisa tdipisa added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Feb 20, 2023
dsuren1 pushed a commit that referenced this pull request Feb 21, 2023
@allyoucanmap
#8959 Add hide options for service selector of LayerDownload plugin (#…
a82f99e 
…8960) (#8963)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement geonode_integration Internal
4 participants
@allyoucanmap @dsuren1 @ElenaGallo @tdipisa