Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8965 Allow map widgets also in 3D mode #9084

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR removes the checks to disable widgets for 3D maps. Parts of this issue was already implemented in #8990 in particular the computation of the bounds used to filter widgets content using the computeViewRectangle method from cesium

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#8965

What is the new behavior?

The Widgets are visible on top of the 3D maps

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added enhancement Widgets 3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT labels Apr 7, 2023
@allyoucanmap allyoucanmap added this to the 2023.02.00 milestone Apr 7, 2023
@allyoucanmap allyoucanmap self-assigned this Apr 7, 2023
@allyoucanmap allyoucanmap linked an issue Apr 7, 2023 that may be closed by this pull request
6 tasks
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@offtherailz offtherailz merged commit 44330d9 into geosolutions-it:master Apr 13, 2023
@offtherailz
Copy link
Member

@ElenaGallo, could you please test this on DEV ? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT enhancement Widgets
2 participants