#9553: Improving readability of long attribute values in attribute table and table widgets #9701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user hovers on cell
…nd use it for formatter table cell
6 tasks
MV88
requested changes
Nov 14, 2023
web/client/components/misc/enhancers/handleLongTextEnhancer.jsx
Outdated
Show resolved
Hide resolved
web/client/components/misc/enhancers/handleLongTextEnhancer.jsx
Outdated
Show resolved
Hide resolved
web/client/components/misc/enhancers/handleLongTextEnhancer.jsx
Outdated
Show resolved
Hide resolved
MV88
reviewed
Nov 15, 2023
web/client/components/misc/enhancers/handleLongTextEnhancer.jsx
Outdated
Show resolved
Hide resolved
MV88
approved these changes
Nov 15, 2023
|
@ElenaGallo please test it in DEV |
MV88
added
the
BackportNeeded
|
Test passed, @mahmoudadel54 please backport to 2023.02.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Nov 21, 2023
…in attribute table and table widgets (geosolutions-it#9701) * geosolutions-it#9553: handle showing tooltip on attr table cells once user hovers on cell * geosolutions-it#9553: create a separate enhnacer for handleLongText and use it for formatter table cell * geosolutions-it#9553: add copyright for the created handleLongTextEnhancer * geosolutions-it#9553: handle test cases for handleLongTextEnhancer * geosolutions-it#9553: add unit tests for handleLongTextEnhancer * geosolutions-it#9553: fix unit test failure for featureTypeToGridColumns formatters * geosolutions-it#9553:reset tests.webpack file * Update web/client/components/misc/enhancers/handleLongTextEnhancer.jsx --------- Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com>
Backport is done --- > #9719 |
MV88
added a commit
that referenced
this pull request
Nov 22, 2023
…ble and table widgets (#9701) (#9719) * #9553: handle showing tooltip on attr table cells once user hovers on cell * #9553: create a separate enhnacer for handleLongText and use it for formatter table cell * #9553: add copyright for the created handleLongTextEnhancer * #9553: handle test cases for handleLongTextEnhancer * #9553: add unit tests for handleLongTextEnhancer * #9553: fix unit test failure for featureTypeToGridColumns formatters * #9553:reset tests.webpack file * Update web/client/components/misc/enhancers/handleLongTextEnhancer.jsx --------- Co-authored-by: Matteo V <matteo.velludini@geosolutionsgroup.com>
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I handled showing a tooltip for long attribute value in attribute table and table widgets only if user hovers on the cells that has shown content less than the attribute value.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9553
What is the current behavior?
#9553
What is the new behavior?
Showing a tooltip for long attribute value in attribute table and table widgets only if user hovers on the cells that has shown content less than the attribute value.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
I created a generic enhancer with name "handleLongTextEnhancer" to handle the tooltip for long content