-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9830: Support for IFC as a further 3D model managed by MapStore #9908
#9830: Support for IFC as a further 3D model managed by MapStore #9908
Conversation
Description: - Handle import ifc model to the 3d map - Adding ifc model layer to catalog
Description: - Creating ModelTransformation component that handle moving the model center via display TOC settings for 'model' layers - Add translations - Handle show/hide the model layers via TOC - Handle logic on show/hide 'model' layers based on max/min scale in display TOC settings
Description: - Doing some Refactors in ModelLayer - Write unit tests - Edit translations
Description: - Edit testConfig file by adding a proxies property in testConfig to enable using web-ifc test - Replace fetch with axios in fetching ifc file via url - Edit unit test of "Model-test" file due to testConfig edits
Description: - Remove the dummy ifc layers from new.json file
Description: - Hide opacity from display tab for ifc model - Write unit tests - Update copyright year for the new created files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, some inline requested changes and the following task to complete:
- Take a look to this commit 4715e57 where some properties changes has been introduced
// sample configuration
{
"id": "model-01",
"type": "model",
"url": " /models/example.ifc",
"name": "Model",
"title": "Model",
"visibility": true,
"features": [
{
"type": "Feature",
"id": "model-origin",
"properties": {
"heading": 45,
"pitch": 0,
"roll": 0,
"scale": 10
},
"geometry": {
"type": "Point",
"coordinates": [8.9463, 44.4056, 0]
}
}
]
}
- Add dev documentation related to model layer in maps-configuration.md file
- [TBD] Verify if it's possible to get information related to the projection from IFC files (Do we have some examples?)
- [TBD] At the moment adding opacity could be complex so we excluded opacity property similar to 3d tiles. Could this work?
- [TBD] Interaction with the map to adjust the model are not currently implemented. My proposal is to verify the feasibility in a separate issue
Nice to have in UI, to discuss:
- Add input settings fields to update rotations: heading, roll and pitch
- Add input settings field to change the scale
- Add an options to visualize the origin of the model with a marker
web/client/components/TOC/fragments/settings/ModelTransformation.jsx
Outdated
Show resolved
Hide resolved
web/client/components/TOC/fragments/settings/ModelTransformation.jsx
Outdated
Show resolved
Hide resolved
web/client/components/TOC/fragments/settings/ModelTransformation.jsx
Outdated
Show resolved
Hide resolved
Description: - Resolve review comments includes: * edit in translation files * remove unused comments
Let's check with a georeferenced IFC file, then manage the functionality to automatically zoom to the IFC file if georeferenced or place the model in the center of the viewport for now that's enough
no for now
let's create a dedicated issue
no for now, we can maybe open an issue anyway for future improvements. |
Description: - Add dev documentation related to model layer in maps-configuration.md file - Manage the functionality to automatically zoom to the IFC file if georeferenced or place the model in the center of the viewport - edit unit cases based on changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new logic for the projected IFC4 model is good, I introduced some logic to complete and there are some failing tests to check.
There is still a misalignment with the rotation but the computation seems correct
…ommnets) - double check of setting COORDINATE_TO_ORIGIN by false to avoid translating the model to the origin - Showing warning messages if user add non-referenced ifc model or ifc model with non supported projection - Add translations - Write unit tests
…ommnets) - edit in translations - Add refactor code for getting ifc data by using cache approach
- fix unit test failure FE
@ElenaGallo please test this feature on dev, thanks |
@mahmoudadel54 I noticed that when adding the model to the map, the map is not zoomed correctly. See the video below: center.mp4I use this map with this model url |
@ElenaGallo @mahmoudadel54 (FYI @allyoucanmap) @mahmoudadel54 @allyoucanmap is it possible to indicate it in the popup when this kind of error occurs? I think it would make the MS notification more useful. |
@ElenaGallo @allyoucanmap @mahmoudadel54 now also that CRS is supported in DEV.
Does it maybe depend on the model origins @mahmoudadel54 @allyoucanmap? |
Description
This PR includes these points below:
1 - Adding IFC model layer to the catalog so IFC Model is included as layer now in catalog.
2 - Handling Workflow for import and visualize an ifc on map
3 - Handling Identify workflow for IFC objects
4 - Handling some panel settings options like:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9830
What is the current behavior?
#9830
What is the new behavior?
IFC Model support is added for 3d map as a layer
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information