Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9583 Fix SaveAs plugin showing persisted data #9984

Merged

Conversation

Igi-ID
Copy link
Contributor

@Igi-ID Igi-ID commented Feb 21, 2024

Description

This PR introduces a fix for the SaveAs plugin showing persisted resource metadata in the modal fields, while the plugin itself is used to create a new resource. Fields such as creator, editor, created, lastUpdate are now omitted and advertised reverts to default.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
Reported issue
#

What is the new behavior?
Fields are not shown, as mentioned in the description.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Added unadvertised field in Metadata.jsx, shown in modal form. Checkbox, controlled.
Adjust handleResourceData.jsx enhancer, include unadvertised field from resource originalData unto props passed to Metadata.jsx.

Added translations for unadvertised field.
…r, created, lastUpdate and advertised are now removed and will not be shown / default to unspecified.
@Igi-ID Igi-ID added this to the 2024.01.00 milestone Feb 21, 2024
@Igi-ID Igi-ID self-assigned this Feb 21, 2024
@Igi-ID Igi-ID linked an issue Feb 21, 2024 that may be closed by this pull request
6 tasks
@Igi-ID Igi-ID mentioned this pull request Feb 21, 2024
5 tasks
@offtherailz offtherailz enabled auto-merge (squash) February 21, 2024 15:06
@offtherailz
Copy link
Member

offtherailz commented Feb 21, 2024

@ElenaGallo, could you please test this on DEV, as well as it is merged and deployed ? Thank you

@offtherailz offtherailz merged commit f154a58 into geosolutions-it:master Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants