Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/publishing(nodejs): id-token: write for npm publish with --provenance #33569

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

revi
Copy link
Contributor

@revi revi commented Jun 19, 2024

Why:

NPM refuses to publish with --provenance unless id-token: write permission is supplied.

npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm error code EUSAGE
npm error Provenance generation in GitHub Actions requires "write" access to the "id-token" permission

I used the {% ifversion artifact-attestations %} as it was there in L60 (where the relevant docs were written), but not sure if this would work well... :P

See also: https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Supply id-token: write permission as documented by NPM.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Jun 19, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

Thanks for submitting a PR to the GitHub Docs project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 19, 2024
@revi
Copy link
Contributor Author

revi commented Jun 19, 2024

Thanks for submitting a PR to the GitHub Docs project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

Well,

From the docs

Who can use this feature?

People with push access to the upstream repository of a fork owned by a personal account can commit to the forked branches.

This repo is owned by org, thus there is no such option. (And no, I am not going to move to my personal account just for this.) If this is really a blocker, feel free to close this and do it on your version.

Copy link
Contributor

github-actions bot commented Jun 19, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/publishing-packages/publishing-nodejs-packages.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@danuwih

This comment was marked as spam.

@revi
Copy link
Contributor Author

revi commented Jun 19, 2024

Please unsubscribe me from all the email from Github

Very Important

Settings > Notifications

KSDLightermm referenced this pull request Jun 19, 2024
Co-authored-by: Alex Nguyen <150945400+nguyenalex836@users.noreply.github.com>
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 19, 2024
@nguyenalex836
Copy link
Contributor

@revi Thanks so much for opening a PR! I'll get this triaged for review ✨

revi added 2 commits June 25, 2024 20:39
…`--provenance`

NPM refuses to publish with `--provenance` unless `id-token: write` permission is supplied.

```
npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
npm error code EUSAGE
npm error Provenance generation in GitHub Actions requires "write" access to the "id-token" permission
```

See also: https://docs.npmjs.com/generating-provenance-statements#publishing-packages-with-provenance-via-github-actions

Signed-off-by: Yongmin Hong <revi@omglol.email>
[screenshot](https://github.com/github/docs/assets/7630875/55a8f9a7-0d2e-4fff-a181-b90cc239ac16)

Most likely generated because `{% ifversion artifact-attestations %}`
is in their own lines, so put that just before the `permissions:` to
remove that extraneous line.

Signed-off-by: Yongmin Hong <revi@omglol.email>
Copy link
Contributor

@SiaraMist SiaraMist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and updating it, @revi! You did the versioning perfectly too. ✨ I'll go ahead and get this merged.

@SiaraMist SiaraMist added this pull request to the merge queue Jul 12, 2024
Merged via the queue into github:main with commit 183c7ae Jul 12, 2024
44 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
4 participants