Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add focus monitor next/prev command #467

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add focus monitor next/prev command #467

wants to merge 1 commit into from

Conversation

freestingo
Copy link

added new command for moving the focus sequentially between different monitors.
@freestingo freestingo force-pushed the feature/add-focus-monitor-command branch 2 times, most recently from e72442a to 4eba0ba Compare December 13, 2023 18:36
@lars-berger
Copy link
Collaborator

Hey, thanks for the PR 🙌The actual code looks fantastic but I'd suggest we change from focus monitor <prev | next> to focus monitor <left | right | up | down>.

The monitor sequence is more of an internal implementation and they aren't guaranteed to be in a left-to-right order. And I can imagine it could be confusing to determine next/prev for people who have unorthodox setups with monitors stacked vertically etc.

We currently don't have a command for focusing to a monitor in direction, and it'd help with getting more i3wm features moved over. If you're down to make the change, lmk 👍 We have a utility for getting a monitor in a given direction via MonitorService.GetMonitorInDirection.
@freestingo freestingo force-pushed the feature/add-focus-monitor-command branch from 4eba0ba to 976be80 Compare January 27, 2024 08:54
@freestingo
Copy link
Author

@lars-berger just pushed a new version that supports focusing monitors in a given direction according to your feedback :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@freestingo @lars-berger