Add scene renderer class #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hai Nguyen <chaoticbob@users.noreply.github.com> Co-authored-by: Aliya Pazylbekova <apazylbe@users.noreply.github.com>
anishmgoyal
force-pushed
the
addSceneRenderer
branch
from
9bf6903
to
9a89b9b
Compare
footballhead
reviewed
May 8, 2024
| @@ -20,3 +20,4 @@ add_subdirectory(fluid_simulation/shaders) | |||
| add_subdirectory(gbuffer/shaders) | |||
| add_subdirectory(materials/shaders) | |||
| add_subdirectory(oit_demo/shaders) | |||
| add_subdirectory(scene_renderer/shaders) | |||
There was a problem hiding this comment.
Can we move this into it's own PR? These shaders are already checked in and this is needed to use them
There was a problem hiding this comment.
Done in #470. This line can be removed from this PR.
apazylbe
added a commit
to apazylbe/bigwheels
that referenced
this pull request
May 24, 2024
Since shaders are already checked in. This line is taken out of this PR: google#427
apazylbe
added a commit
to apazylbe/bigwheels
that referenced
this pull request
May 28, 2024
Since shaders are already checked in. This line is taken out of this PR: google#427
apazylbe
added a commit
that referenced
this pull request
May 28, 2024
Since shaders are already checked in. This line is taken out of this PR: #427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.